Skip to content

Merge stochastic physics (SPPT only) into GSL's develop branch#239

Draft
gsketefian wants to merge 167 commits into
ufs-community:noaa/developfrom
dtcenter:gsl/MPAS_stoch_physics_try_merge_stoch_master
Draft

Merge stochastic physics (SPPT only) into GSL's develop branch#239
gsketefian wants to merge 167 commits into
ufs-community:noaa/developfrom
dtcenter:gsl/MPAS_stoch_physics_try_merge_stoch_master

Conversation

@gsketefian
Copy link
Copy Markdown

@gsketefian gsketefian commented Mar 31, 2026

This PR enables use of the SPPT scheme of stochastic physics into MPAS-Model. This is addressed in Issue #204.

Main changes:

  1. Bring in the stochastic_physics code as a submodule.
  2. Make changes to Makefiles, registry xml files, and fortran files to allow the SPPT stochastic scheme to bue used with MPAS.
  3. Adds the stochastic_physics code as a submodule. There is a companion PR into the authoritative stochastic_physics repo here.

Note that this PR still requires make to be used to build MPAS-Model with stochastic physics. The ability to build with cmake will come in a separate PR.

Mandatory Questions

  • Does this PR include any additions or changes to external inputs (e.g., microphysics lookup tables, static data for gravity-wave drag -- things like that)?
    • No
  • Does this PR require updating one or more baselines for the CI tests? If so, what?
    • Yes. We would like to add at least one test that runs MPAS with SPPT enabled. We are also curious about how to include regression tests if those are used in this repo.

Priority Reviewers

gsketefian and others added 30 commits September 12, 2025 12:36
…he stochastic_physics submodule itself will be added in a separate commit.
…'t updated during latest merge of gsl/develop.
…he gsl/MPAS_stoch_physics in the stochastic_physics repo.
… smoke) from "output" to "output_smoke" (and file from "history..." to "history_smoke...". This is necessary because the stream name "output" is already taken by the main output stream, and having the same name for two different output streams apparently causes SMIOL I/O errors during the forecast (and incorrect/corrupted history*.nc files).
…) no stale stream_list.atmosphere files exist in the two default_inputs directories (one under core_atmosphere and the other immediately under the MPAS-Model top-level directory), and (2) for the atmosphere core, all files (stream-related as well as namelist) in the top-level directory are backed up before new such files are copied from the default_inputs directory back up a level into the top-level directory. Previously, existing (and thus possibly outdated) stream_list.atmosphere.* files in the top-level directory were not being replaced by newer ones in default_inputs, and that was causing unexpected (and wrong) behavior. Probably a similar fix is needed for the init_atmsophere core and maybe even other ones.
…ll as its output file) so it doesn't conflict with the default output stream.
…tochastic_physics's master branh will gradually happen.
…tochastic_physics code know that the dycore being used is MPAS.
…ill instead be defined in the Makefile for stochastic_physics only (in a separate commit into the stochastic_physics repo) since it is only needed by the stochastic_physics submodule.
…e that is now added in the Makefile in stochastic_physics).
@JeffBeck-NOAA
Copy link
Copy Markdown
Collaborator

@gsketefian, once @dustinswales' changes are merged into both PRs, can you run the MPAS-Model CI test using the 'hrrrv5' physics suite with SPPT? It should hopefully work as expected (no r[u/v]cuten perturbations will be applied). Thanks!

@dustinswales
Copy link
Copy Markdown
Collaborator

@gsketefian I see a new stochastic-physics test with a green check mark!
Can you revert your changes to the other CI scripts to see if they run?

gsketefian added 19 commits May 19, 2026 18:35
…d into the artifact (useful when the artifact is too large, e.g. for downloading in a reasonable time, if all files in the run directory are included).
…r to the ones in ufscommunity.convection_permitting.gfs.winter (without the .stoch at the end).
… CI testing of convection_permitting suite since the latter uses the Thompson MP scheme. Also, remove the physics_lsm_noahmp namelist since the convection_permitting scheme doesn't need it (it uses the noah lsm, not noahmp).
…ng changed to TEMPO (the Thompson scheme, which is part of convection_permitting, is being used), we need to add links to the Thompson tables. Do that here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: DRAFT

Development

Successfully merging this pull request may close these issues.

6 participants